[full-ci] [tests-only] Test expose group displayname #749

phil-davis · 2022-07-28T10:49:38Z

This is on top of PR #748 - I can run full-ci here, and work on fixing the tests. When it works, the needed changes can be distributed to the original PR, core etc - wherever they are needed.

phil-davis · 2022-08-02T14:48:32Z

https://drone.owncloud.com/owncloud/user_ldap/4065/71/19

runsh: Total unexpected failed scenarios throughout the test run:
apiCapabilities/capabilities.feature:821
apiCapabilities/capabilities.feature:850
apiCapabilities/capabilities.feature:882
apiCapabilities/capabilities.feature:914

Group with a # in the name fails.

https://drone.owncloud.com/owncloud/user_ldap/4065/76/19

runsh: Total unexpected failed scenarios throughout the test run:
apiShareManagementBasicToRoot/createShareToRootFolder.feature:387
apiShareManagementBasicToRoot/createShareToRootFolder.feature:388

Group names with emojis are not working.

https://drone.owncloud.com/owncloud/user_ldap/4065/77/19

runsh: Total unexpected failed scenarios throughout the test run:
apiShareManagementBasicToShares/createShareToSharesFolder.feature:427
apiShareManagementBasicToShares/createShareToSharesFolder.feature:428

Group names with emojis are not working.
https://drone.owncloud.com/owncloud/user_ldap/4065/87/19

runsh: Total unexpected failed scenarios throughout the test run:
apiTags/assignTags.feature:89

Group with a # in the name fails.

There is some problem with group names that have special characters. I guess that there is some escaping needed somewhere.

@jvillafanez maybe you can see straight away if there is a simple fix.

jvillafanez · 2022-08-02T15:41:39Z

It follows the same sanitation rules as with the username (

user_ldap/lib/Access.php

Lines 587 to 593 in 8ba4029

    
           if ($nameAttribute !== '') { 
        
           	$name = $this->readAttribute($fdn, $nameAttribute); 
        
           	$name = $name[0]; 
        
           } else { 
        
           	$name = $uuid; 
        
           } 
        
           $intName = $this->sanitizeUsername($name);

).

I've adjusted the code to sanitize only the username while leaving the groupname without changes. That should also help with the migration: current groups containing any of those chars should still be linked correctly after the migration.